Set LEVEL_DETECTOR_SPL_8BIT_000_POINT to 52.0 dB.
#174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the value currently used by MakeCode: https://github.com/microsoft/pxt-microbit/blob/v7.1.3/libs/microphone/microphone.cpp#L8 And MicroPython: https://github.com/microbit-foundation/micropython-microbit-v2/blob/v2.1.2/src/codal_app/codal.json#L16 The reason to change it is that the LevelDetectorSPL() minValue default parameter is already 52: https://github.com/lancaster-university/codal-core/blob/509086cc8590465041b15493ab52b56e7071c110/inc/streams/LevelDetectorSPL.h#L124 MicroBitAudio also sets it to the same value: https://github.com/lancaster-university/codal-microbit-v2/blob/v0.2.68/source/MicroBitAudio.cpp#L82 And LevelDetectorSPL will clamp as that being the min. https://github.com/lancaster-university/codal-core/blob/509086cc8590465041b15493ab52b56e7071c110/source/streams/LevelDetectorSPL.cpp#L142-L147
|
Thanks @microbit-carlos. With the update sound work I've been working on, we should be able to get back to the 35db point on a microbit v2 though. I'll test if that's the case, and if so, suggest we revert back to 35db? |
|
I've updated the code in the audio-refactor branch, and it does indeed now allow us to detect down to around 35db. Shall we leave this as it is, then accept the improved range when we merge that branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the value currently used by MakeCode:
https://github.com/microsoft/pxt-microbit/blob/v7.1.3/libs/microphone/microphone.cpp#L8
And MicroPython:
https://github.com/microbit-foundation/micropython-microbit-v2/blob/v2.1.2/src/codal_app/codal.json#L16
The reason to change it is that the LevelDetectorSPL() minValue default parameter is already 52:
codal-core/inc/streams/LevelDetectorSPL.h
Lines 123 to 126 in 509086c
MicroBitAudio also sets it to the same value 52.0:
https://github.com/lancaster-university/codal-microbit-v2/blob/v0.2.68/source/MicroBitAudio.cpp#L82
And LevelDetectorSPL will clamp as that being the min.
codal-core/source/streams/LevelDetectorSPL.cpp
Lines 142 to 147 in 509086c
Fixes lancaster-university/codal-microbit-v2#449.